0AyanamiRei commented on PR #67874: URL: https://github.com/apache/doris/pull/67874#issuecomment-5758009660
Absorbed into the Kinesis shard topology change, closing this draft. - `data_consumer.cpp`: an empty `GetRecords` response no longer ends the round; the shard stays in the active set and the returned `NextShardIterator` is followed, exactly as in this PR (the surrounding lines were rewritten by the queue/marker change, so the hunk is not textually identical). - `be/test/runtime/kinesis_empty_page_test.cpp`: added, with the queue type adapted from `BlockingQueue<std::shared_ptr<Record>>` to `BlockingQueue<KinesisQueueItem>` and the assertion moved to `item.record`. That is the interface mismatch anticipated when this PR is stacked on the queue change; it is resolved here. An empty page is now also what makes the "shard has not reached its tip" case explicit in the state machine: only an empty `NextShardIterator` produces the end-of-shard marker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
