cambyzju commented on code in PR #16485:
URL: https://github.com/apache/doris/pull/16485#discussion_r1099818062
##########
be/src/io/cache/block/cached_remote_file_reader.cpp:
##########
@@ -44,12 +44,13 @@ Status CachedRemoteFileReader::close() {
std::pair<size_t, size_t> CachedRemoteFileReader::_align_size(size_t offset,
size_t
read_size) const {
+ size_t segment_size = std::min(std::max(read_size, (size_t)4096), // 4k
+
(size_t)config::file_cache_max_file_segment_size);
Review Comment:
it is better to add a CONF_Validator(>=4096) for
`file_cache_max_file_segment_size`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
