deardeng commented on PR #67636:
URL: https://github.com/apache/doris/pull/67636#issuecomment-5758746671
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67636
commit: 5bb77795f96d950bf172788937ad42c8113025d3
base: 1378d72082fc6d2600088c63e74bfb932bf93b0d
reviewed_at: 2026-09-21T18:06+08:00
reviewer: deardeng
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-01 (Minor, resource-leak, not a regression)
`fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudEnv.java:117-119`:
disabling and re-enabling cleanup within a running scan can acknowledge a
partial pass. Skipped stale routes remain until another cleanup trigger;
preserve an interrupted result and retry the next enabled batch. An independent
severity challenge upheld Minor against the merge base.
-
`fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:1410`:
review covers the declared active-catalog scope. Recycle-bin sweeping and
budgeted full-catalog cleanup remain explicitly deferred; large-catalog latency
was not measured.
-
`fe/fe-core/src/test/java/org/apache/doris/master/CheckpointTest.java:94-96`:
static review only; no builds or tests run. Checkpoint cases call the helper
with mocked partition traversal, and the empty-topology rebalancer case checks
the gate rather than a full cleanup integration.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
