airborne12 commented on code in PR #67918:
URL: https://github.com/apache/doris/pull/67918#discussion_r4062788440
##########
be/src/storage/index/inverted/similarity/predicate_collector.cpp:
##########
@@ -376,8 +378,9 @@ Status MatchPredicateCollector::collect(RuntimeState*
state, const TabletSchemaS
DORIS_CHECK(analyzer_ctx != nullptr);
const auto query_type = match_query_type(expr->op());
DORIS_CHECK(query_type != InvertedIndexQueryType::UNKNOWN_QUERY);
- const auto* index_meta = DORIS_TRY(select_index_meta(
- candidates.index_metas, candidates.field_type, query_type,
analyzer_ctx->analyzer_key));
+ const auto* index_meta = DORIS_TRY(
Review Comment:
Fixed in 20c49dde. `analyze_plain_query` now returns
`Result<vector<TermInfo>>`, catches both `CLuceneError` and `doris::Exception`,
and converts analyzer failures to `INVERTED_INDEX_ANALYZER_ERROR`; scoring
callers propagate them with `DORIS_TRY`. Added analyzer-provider failure
coverage that verifies an error Status, no escaped exception, and an empty
collection; the related ASAN BE suite passes 147/147.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
