This is an automated email from the ASF dual-hosted git repository.
gabriellee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new d1c6b81140 [Bug](log) add some log to find out bug (#16518)
d1c6b81140 is described below
commit d1c6b8114053e8c754c979d8d3fbf5c880d361d2
Author: Gabriel <[email protected]>
AuthorDate: Wed Feb 8 21:23:02 2023 +0800
[Bug](log) add some log to find out bug (#16518)
---
be/src/vec/exec/vaggregation_node.cpp | 3 +++
.../src/main/java/org/apache/doris/planner/AggregationNode.java | 4 ++++
.../src/main/java/org/apache/doris/planner/PlanFragment.java | 4 ++++
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java | 9 +++++++++
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java | 6 ++++++
5 files changed, 26 insertions(+)
diff --git a/be/src/vec/exec/vaggregation_node.cpp
b/be/src/vec/exec/vaggregation_node.cpp
index c2b016d554..2344b126c3 100644
--- a/be/src/vec/exec/vaggregation_node.cpp
+++ b/be/src/vec/exec/vaggregation_node.cpp
@@ -117,6 +117,9 @@ AggregationNode::AggregationNode(ObjectPool* pool, const
TPlanNode& tnode,
tnode.agg_node.use_fixed_length_serialization_opt;
_agg_data = std::make_unique<AggregatedDataVariants>();
_agg_arena_pool = std::make_unique<Arena>();
+ if (_needs_finalize && id() == 27) {
+ LOG(INFO) << "Log for ISSUE-16517: " << _row_descriptor.debug_string();
+ }
}
AggregationNode::~AggregationNode() = default;
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/planner/AggregationNode.java
b/fe/fe-core/src/main/java/org/apache/doris/planner/AggregationNode.java
index 0e69bfba07..9b8fae13db 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/AggregationNode.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/AggregationNode.java
@@ -247,6 +247,10 @@ public class AggregationNode extends PlanNode {
super.debugString()).toString();
}
+ public boolean isTargetNode() {
+ return id.asInt() == 27 && needsFinalize;
+ }
+
@Override
protected void toThrift(TPlanNode msg) {
aggInfo.updateMaterializedSlots();
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/planner/PlanFragment.java
b/fe/fe-core/src/main/java/org/apache/doris/planner/PlanFragment.java
index a30eca1171..bf34c52651 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/PlanFragment.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/PlanFragment.java
@@ -406,6 +406,10 @@ public class PlanFragment extends TreeNode<PlanFragment> {
return fragmentId;
}
+ public boolean hasTargetNode() {
+ return planRoot.isTargetNode();
+ }
+
public Set<RuntimeFilterId> getBuilderRuntimeFilterIds() {
return builderRuntimeFilterIds;
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java
b/fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java
index 241b7eed93..4c6cf88fad 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java
@@ -207,6 +207,15 @@ public abstract class PlanNode extends TreeNode<PlanNode>
implements PlanStats {
this.statsDeriveResult = statsDeriveResult;
}
+ public boolean isTargetNode() {
+ for (PlanNode node : children) {
+ if (node.isTargetNode()) {
+ return true;
+ }
+ }
+ return false;
+ }
+
/**
* Sets tblRefIds_, tupleIds_, and nullableTupleIds_.
* The default implementation is a no-op.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
index 98aeb7a6fe..6077291077 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
@@ -280,6 +280,12 @@ public class Coordinator {
this.descTable = planner.getDescTable().toThrift();
}
+ for (PlanFragment fragment : fragments) {
+ if (fragment.hasTargetNode()) {
+ LOG.info("Log for ISSUE-16517: " + this.descTable.toString());
+ }
+ }
+
this.returnedAllResults = false;
this.enableShareHashTableForBroadcastJoin =
context.getSessionVariable().enableShareHashTableForBroadcastJoin;
this.enablePipelineEngine =
context.getSessionVariable().enablePipelineEngine;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
