github-actions[bot] commented on code in PR #68354: URL: https://github.com/apache/doris/pull/68354#discussion_r4068053557
########## regression-test/suites/external_table_p0/remote_doris/test_remote_doris_variant_select.groovy: ########## @@ -1,177 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -suite("test_remote_doris_variant_select", "p0,external") { - String remote_doris_host = context.config.otherConfigs.get("extArrowFlightSqlHost") - String remote_doris_arrow_port = context.config.otherConfigs.get("extArrowFlightSqlPort") - String remote_doris_http_port = context.config.otherConfigs.get("extArrowFlightHttpPort") - String remote_doris_user = context.config.otherConfigs.get("extArrowFlightSqlUser") - String remote_doris_psw = context.config.otherConfigs.get("extArrowFlightSqlPassword") - String remote_doris_thrift_port = context.config.otherConfigs.get("extFeThriftPort") - - def showres = sql "show frontends"; - remote_doris_arrow_port = showres[0][6] - remote_doris_http_port = showres[0][3] - remote_doris_thrift_port = showres[0][5] - log.info("show frontends log = ${showres}, arrow: ${remote_doris_arrow_port}, http: ${remote_doris_http_port}, thrift: ${remote_doris_thrift_port}") - - def showres2 = sql "show backends"; - log.info("show backends log = ${showres2}") - - def db_name = "test_remote_doris_variant_select_db" - def catalog_name = "test_remote_doris_variant_select_catalog" - def catalog_arrow_name = "test_remote_doris_variant_select_catalog_with_arrow" - - sql "set enable_agg_state=true" - - sql """DROP DATABASE IF EXISTS `${db_name}`""" - - sql """CREATE DATABASE IF NOT EXISTS `${db_name}`""" - - sql """ Review Comment: [P1] Preserve this remote VARIANT regression The reported `Variant(0)` to `Variant(2048)` fixture failure already has a narrow repository precedent: set `default_variant_max_subcolumns_count = 0` before creating the table so the bare VARIANT metadata matches `parse_to_variant()` (see `regression-test/suites/variant_p0/v2/with_index/test_variant_v2_snii_index.groovy`). Removing the suite instead drops the only located remote-Doris coverage for bare/dynamic heterogeneous VARIANT values, nested predicates/projections/aggregates, source-versus-catalog comparison, and the end-to-end Arrow rejection; surviving remote tests use predefined schemas and the BE unit test only exercises the validator helper. Please retain the suite and align its setup rather than deleting it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
