github-actions[bot] commented on code in PR #68356: URL: https://github.com/apache/doris/pull/68356#discussion_r4068067584
########## regression-test/suites/external_table_p0/remote_doris/test_remote_doris_variant_select.groovy: ########## @@ -1,177 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -suite("test_remote_doris_variant_select", "p0,external,doris,external_docker,external_docker_doris") { - String remote_doris_host = context.config.otherConfigs.get("extArrowFlightSqlHost") - String remote_doris_arrow_port = context.config.otherConfigs.get("extArrowFlightSqlPort") - String remote_doris_http_port = context.config.otherConfigs.get("extArrowFlightHttpPort") - String remote_doris_user = context.config.otherConfigs.get("extArrowFlightSqlUser") - String remote_doris_psw = context.config.otherConfigs.get("extArrowFlightSqlPassword") - String remote_doris_thrift_port = context.config.otherConfigs.get("extFeThriftPort") - - def showres = sql "show frontends"; - remote_doris_arrow_port = showres[0][6] - remote_doris_http_port = showres[0][3] - remote_doris_thrift_port = showres[0][5] - log.info("show frontends log = ${showres}, arrow: ${remote_doris_arrow_port}, http: ${remote_doris_http_port}, thrift: ${remote_doris_thrift_port}") - - def showres2 = sql "show backends"; - log.info("show backends log = ${showres2}") - - def db_name = "test_remote_doris_variant_select_db" - def catalog_name = "test_remote_doris_variant_select_catalog" - def catalog_arrow_name = "test_remote_doris_variant_select_catalog_with_arrow" - - sql "set enable_agg_state=true" - - sql """DROP DATABASE IF EXISTS `${db_name}`""" - - sql """CREATE DATABASE IF NOT EXISTS `${db_name}`""" - - sql """ - CREATE TABLE `${db_name}`.`test_remote_doris_variant_select_t` ( - `id` INT NOT NULL, - `v` VARIANT NULL, Review Comment: [P2] Keep the remote VARIANT coverage by aligning these types The reported insert failure is repairable within this test: `parse_to_variant` produces `Variant(max subcolumns count = 0)`, while the bare `VARIANT` here picks up the session default of 2048, and the legacy BE cast path rejects property-different Variant-to-Variant casts. Setting `default_variant_max_subcolumns_count=0` before this DDL (or declaring this column with max-subcolumns 0) aligns the types and avoids that cast. Deleting the file instead also removes the only remote-Doris coverage for dynamic/mixed VARIANT roots, nested predicates and aggregates, source-vs-catalog comparisons, and the Arrow rejection; the surviving suite only exercises predefined object rows and one string subpath. Please retain or migrate those assertions rather than remove them; when restoring the Arrow check, update its expected substring to the current `Variant is supported only for Parquet files and WAL` wording. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
