github-actions[bot] commented on code in PR #68180:
URL: https://github.com/apache/doris/pull/68180#discussion_r4069202854
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/MTMV.java:
##########
@@ -423,6 +437,10 @@ public void alterMvProperties(AlterMTMV alterMTMV, boolean
isReplay) {
}
}
}
+ if (containsSyncWindow && ivmInfo != null && ivmInfo.isEnableIvm()
Review Comment:
[P2] Only require COMPLETE when the effective window can add previously
skipped partitions. The raw inequality also fires for configurations with
identical behavior (for example, changing time unit with no positive limit, or
absent -> default DAY) and for a monotonic narrowing such as limit 10 -> 1 with
the same unit/format. The latter only removes old MV partitions:
`syncPartitionsIfNeeded` would drop them before planning, and any later
widening is the point that must rebuild skipped data. Instead, this barrier
makes strict INCREMENTAL fail before sync and makes AUTO rebuild the entire MV.
Please compare normalized configs and distinguish narrowing from
widening/removal; narrowing may still need a schema-generation bump to reject
an old in-flight task, but not a COMPLETE baseline. Add negative tests for
inactive/default-equivalent changes and for a positive-limit narrowing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
