github-actions[bot] commented on code in PR #67627:
URL: https://github.com/apache/doris/pull/67627#discussion_r4070014219
##########
be/src/udf/python/python_server.py:
##########
@@ -29,6 +29,7 @@
import time
import threading
import pickle
+import uuid
Review Comment:
[P1] Reserve uuid in the module loader — `ModuleUDFLoader` clears a UDF's
top-level name from `sys.modules` and therefore forbids names already imported
by this server, but this new import is not added to `_FORBIDDEN_MODULE_NAMES`.
Loading a supported UDF module named `uuid` first evicts this stdlib module; a
later UDF then imports a fresh stdlib `uuid`, and the valid UUID it returns
fails the new `isinstance(value, uuid.UUID)` check because the class objects
come from different module instances. Please reserve `uuid` in the forbidden
set and cover this loader sequence so UUID-returning module UDFs keep working.
##########
regression-test/data/datatype_p0/uuid/test_uuid_map_matrix.out:
##########
@@ -0,0 +1,8059 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !unary_fe_c_0 --
+0 \N \N \N \N \N \N \N \N \N
\N
+1 \N \N \N \N \N \N \N \N \N
\N
+2 \N \N \N \N \N \N \N \N \N
\N
+3 \N \N \N \N \N \N \N \N \N
\N
+4 \N \N \N \N \N \N \N \N \N
\N
+5 \N \N \N \N \N \N \N \N \N
\N
+6 \N \N \N \N \N \N \N \N \N
\N
+7 \N \N \N \N \N \N \N \N \N
\N
+8 \N \N \N \N \N \N \N \N \N
\N
+9 \N \N \N \N \N \N \N \N \N
\N
+
+-- !unary_fe_c_1 --
+0 [] [] 0 {} {} {} false true []
{}
+1 [] [] 0 {} {} {} false true []
{}
+2 [] [] 0 {} {} {} false true []
{}
+3 [] [] 0 {} {} {} false true []
{}
+4 [] [] 0 {} {} {} false true []
{}
+5 [] [] 0 {} {} {} false true []
{}
+6 [] [] 0 {} {} {} false true []
{}
+7 [] [] 0 {} {} {} false true []
{}
+8 [] [] 0 {} {} {} false true []
{}
+9 [] [] 0 {} {} {} false true []
{}
+
+-- !unary_fe_c_2 --
+0 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+1 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+2 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+3 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+4 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+5 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+6 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+7 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+8 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+9 ["00000000-0000-0000-0000-000000000001",
"00000000-0000-0000-0000-000000000000"]
["00000000-0000-0000-0000-000000000000", null] 2
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000"}
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":"00000000-0000-0000-0000-000000000000"}
true false [{"key":"00000000-0000-0000-0000-000000000001",
"value":"00000000-0000-0000-0000-000000000000"},
{"key":"00000000-0000-0000-0000-000000000000", "value":null}]
{"00000000-0000-0000-0000-000000000001":"00000000-0000-0000-0000-000000000000",
"00000000-0000-0000-0000-000000000000":null}
+
+-- !unary_fe_c_3 --
+0 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+1 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+2 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+3 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+4 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+5 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+6 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+7 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+8 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+9 ["550e8400-e29b-41d4-a716-446655440000"] [null] 1
{"550e8400-e29b-41d4-a716-446655440000":null} {}
{"550e8400-e29b-41d4-a716-446655440000":"550e8400-e29b-41d4-a716-446655440000"}
false false [{"key":"550e8400-e29b-41d4-a716-446655440000", "value":null}]
{"550e8400-e29b-41d4-a716-446655440000":null}
+
+-- !unary_fe_c_4 --
+0 ["018f0f59-1010-7abc-9234-001122334455"] [null] 1
{"018f0f59-1010-7abc-9234-001122334455":null} {}
{"018f0f59-1010-7abc-9234-001122334455":"018f0f59-1010-7abc-9234-001122334455"}
false false [{"key":"018f0f59-1010-7abc-9234-001122334455", "value":null}]
{"018f0f59-1010-7abc-9234-001122334455":null}
Review Comment:
[P1] Keep these UUID fixtures from failing Gitleaks — The required `Check
for secrets` job on this exact head exits 1 with 33 `generic-api-key` findings,
all caused by the UUID value first shown here and repeated at lines 51-60, 127,
183-192, 259, 315-324, and 391. These are clearly generated test values, but
the committed matrix cannot pass the repository's current scan. Please
regenerate it with a non-triggering UUID that preserves the intended coverage,
or add a narrowly path/value-scoped allowlist rather than weakening the rule
globally.
##########
fe/fe-type/src/main/java/org/apache/doris/catalog/PrimitiveType.java:
##########
@@ -46,6 +46,7 @@ public enum PrimitiveType {
DATETIME("DATETIME", 16, TPrimitiveType.DATETIME, true),
IPV4("IPV4", 4, TPrimitiveType.IPV4, true),
IPV6("IPV6", 16, TPrimitiveType.IPV6, true),
+ UUID("UUID", 16, TPrimitiveType.UUID, true),
Review Comment:
[P2] Include UUID in the COUNT(*) smallest-slot priority — When projection
pruning leaves no required scan slot, `PhysicalPlanTranslator.getSmallestSlot`
retains one column. Its comparator gives fixed-width numeric/date/IP types
priority 1, but UUID matches no category and falls to `Integer.MAX_VALUE`; for
an unpushed `COUNT(*)` (for example on a UNIQUE_KEYS table), a schema with UUID
plus STRING or ARRAY/MAP/STRUCT therefore materializes the
variable-width/complex column instead. Please classify `Type.isUuid()` with the
fixed-width types and add a comparator case where UUID competes with string and
complex slots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
