github-actions[bot] commented on code in PR #68343:
URL: https://github.com/apache/doris/pull/68343#discussion_r4081489885
##########
cloud/src/resource-manager/resource_manager.cpp:
##########
@@ -1442,12 +1439,6 @@ void ResourceManager::refresh_instance(const
std::string& instance_id,
}
}
Review Comment:
[P1] Preserve only clone lineage for deleted instances
After removing this guard, `refresh_instance` falls through into cluster
re-addition and multi-version assignment for a deleted PB. A cache hit is then
accepted without rechecking the persisted `DELETED` status, so this retains
live routing/dispatch state rather than only the B -> A lineage the fix needs.
Please update the source mapping first, then erase
`instance_multi_version_status_` and return before adding clusters for
`DELETED`; the resource-manager test should continue to require missing nodes
and disabled multi-version state while separately requiring the source mapping.
##########
cloud/src/resource-manager/resource_manager.cpp:
##########
@@ -109,9 +109,6 @@ int ResourceManager::init() {
std::unique_lock l(mtx_);
for (auto& [inst_id, inst] : instances) {
- if (inst.status() == InstanceInfoPB::DELETED) {
Review Comment:
[P1] Keep deleted tombstones out of the live startup indexes
This loop does not rebuild `instance_source_snapshot_info_`; it only
populates `node_info_` and `instance_multi_version_status_`. Because
`drop_instance_chain` leaves predecessor clusters in retained tombstones, an MS
restart now re-registers those cloud unique IDs, and `get_instance_id()` trusts
a cache hit without rechecking `DELETED`, so RPCs can be attributed to a
recycled predecessor. Meanwhile clone traversal still cannot use B -> A until
the asynchronous watcher refreshes it (or ever when that watcher is disabled).
Please keep deleted records out of the live indexes and reconstruct valid
source-snapshot mappings separately and synchronously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
