HappenLee opened a new pull request, #68472:
URL: https://github.com/apache/doris/pull/68472
### What problem does this PR solve?
Time-sharing scan pools do not expose `thread_pool_max_queue_size`. Their
initialization registers `thread_pool_max_threads` twice, and the update hook
writes the queue capacity to that same gauge before overwriting it with the
thread limit.
Register and update the existing queue-capacity gauge, following the regular
`ThreadPool` implementation. Add a BE unit test that checks registration and
distinct values for both capacity metrics, then changes the thread limit and
verifies that the queue capacity remains unchanged.
### Release note
Fix the missing `thread_pool_max_queue_size` metric for time-sharing scan
pools.
### Check List (For Author)
- Test: Added
`TimeSharingTaskExecutorTest.test_thread_pool_capacity_metrics`.
- Passed clang-format 16 formatting/check, build hygiene checks, and `git
diff --check`.
- Attempted `./run-be-ut.sh -j 48 --run
--filter=TimeSharingTaskExecutorTest.test_thread_pool_capacity_metrics`; local
CMake configuration failed because OpenMP headers are unavailable (`omp.h` not
found), with faiss/openblas submodules still initializing at the time. The test
has not run locally.
- clang-tidy could not run because the failed configuration did not
generate `compile_commands.json`.
- Behavior changed: Yes, time-sharing scan pools now report their configured
queue capacity.
- Does this need documentation: No, restores an existing thread-pool metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
