HappenLee commented on code in PR #68478:
URL: https://github.com/apache/doris/pull/68478#discussion_r4091220418


##########
be/src/exprs/aggregate/aggregate_function_linear_histogram.cpp:
##########
@@ -34,9 +34,10 @@ AggregateFunctionPtr 
create_aggregate_function_linear_histogram(const std::strin
                                                                 const 
DataTypePtr& result_type,
                                                                 const bool 
result_is_nullable,
                                                                 const 
AggregateFunctionAttr& attr) {
-    using creator = creator_with_type_list<TYPE_TINYINT, TYPE_SMALLINT, 
TYPE_INT, TYPE_BIGINT,
-                                           TYPE_LARGEINT, TYPE_FLOAT, 
TYPE_DOUBLE, TYPE_DECIMAL32,
-                                           TYPE_DECIMAL64, TYPE_DECIMAL128I, 
TYPE_DECIMAL256>;
+    using creator =
+            creator_with_type_list<TYPE_BOOLEAN, TYPE_TINYINT, TYPE_SMALLINT, 
TYPE_INT, TYPE_BIGINT,
+                                   TYPE_LARGEINT, TYPE_FLOAT, TYPE_DOUBLE, 
TYPE_DECIMAL32,
+                                   TYPE_DECIMAL64, TYPE_DECIMAL128I, 
TYPE_DECIMAL256>;

Review Comment:
   DecimalV2 is no longer supported, so we do not need to restore its support 
or test coverage here. This PR focuses on restoring BOOLEAN support for 
`linear_histogram`; no DecimalV2 changes are needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to