airborne12 commented on code in PR #67180: URL: https://github.com/apache/doris/pull/67180#discussion_r4091531842
########## be/src/common/config.cpp: ########## @@ -1319,6 +1319,7 @@ DEFINE_Bool(enable_inverted_index_cache_check_timestamp, "true"); DEFINE_mBool(enable_inverted_index_correct_term_write, "true"); DEFINE_Int32(inverted_index_fd_number_limit_percent, "20"); // 20% DEFINE_Int32(inverted_index_query_cache_shards, "256"); +DEFINE_mDouble(inverted_index_candidate_pushdown_ratio, "0.1"); Review Comment: Confirmed the runtime publication race: set_config could write the ordinary double while SegmentIterator read it. Commit 929f16d5b84 makes scan threads read an atomic snapshot, published at startup and after validated runtime updates. A rejected inf value never reaches that snapshot. The finite/range guard and 0.3 default remain. The ASAN BE build and 18 targeted unit tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
