github-actions[bot] commented on code in PR #68520:
URL: https://github.com/apache/doris/pull/68520#discussion_r4111215576
##########
be/test/storage/index/snii/bench/snii_vs_v3_benchmark_test.cpp:
##########
@@ -1080,7 +1087,10 @@ class DISABLED_SniiVsV3BenchmarkTest : public
::testing::Test {
continue;
}
::fsync(fd);
+ // posix_fadvise is Linux-only; elsewhere the fsync above is all
this can do.
+#if defined(POSIX_FADV_DONTNEED)
Review Comment:
[P2] Do not report fsync-only samples as cold on macOS
On Apple this guard removes the only page-cache eviction operation.
`fsync(fd)` writes dirty data but does not discard clean file pages, so
`_drop_caches()` can leave the just-built/compacted rowset resident. The later
`_resident_pages()` probe only prints one file's retained count and never fails
or skips, and these samples are still aggregated under `cold_query_p50/p99`.
That makes the local benchmark publish warm or partially warm results as cold
on the platform this hunk enables. Please either evict the complete local query
working set with a Darwin-supported mechanism, or fail/skip/unlabel the local
cold phase before its samples are aggregated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
