CalvinKirs commented on PR #68445: URL: https://github.com/apache/doris/pull/68445#issuecomment-5862986282
Local skill review completed at head: no Blocker, Major or Minor finding outstanding, two non-blocking nits. Full report: https://github.com/apache/doris/pull/68445#pullrequestreview-5333766388 The attested review is two passes in the main session with the repo `code-review` skill. Pass 1 went over the whole diff at `27df60e`: for each bumped property, where it is consumed and whether all artifacts moved together; the public API removed between Parquet 1.17.0 and 1.18.0, checked against the 880 runtime jars of the FE modules and BE scanners; class file versions against JDK 17; and which `trino-main` classes reference what `io.airlift:http-server` drops. It raised two Minor findings, the `log4j-1.2-api` version left behind and a wrong exclusion comment, both fixed in `d2795a7`. Pass 2 checked that commit and re-read the whole diff at head, and raised nothing new. An earlier pass by a model the gate does not accept raised the `NonConcurrent Regression` failure; that pass is not part of this attestation, and the author reports that the failure also reproduces on master without this change. CI has not run at `d2795a7` yet. <!-- doris-repo-review:v1:begin --> ```yaml schema: doris-repo-review/v1 status: PASS pr: apache/doris#68445 commit: d2795a7221866bd95fe5044e799fa47b730c56c4 base: f5da8fb165e3abf339354e7d9799c0eb916a3762 reviewed_at: 2026-09-28T11:48:30+08:00 reviewer: CalvinKirs model: claude-fable-5-1 effort: xhigh findings: {blocker: 0, major: 0, minor: 0, nit: 2} rounds: 2 converged: true ``` <!-- doris-repo-review:v1:end --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
