github-actions[bot] commented on code in PR #15917:
URL: https://github.com/apache/doris/pull/15917#discussion_r1102267002
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1449,9 +1573,136 @@ Status SegmentIterator::next_batch(vectorized::Block*
block) {
block->get_by_position(i).column->permute(permutation,
num_rows);
}
+ // LOG(INFO) << "SegmentIterator::next_batch over block: " <<
block->each_col_size();
return Status::OK();
}
+static int execute_remaining_exp_num = 0;
+
+uint16_t SegmentIterator::_execute_remaining_expr(uint16_t* sel_rowid_idx,
uint16_t selected_size,
+ vectorized::Block* block) {
+ SCOPED_RAW_TIMER(&_opts.stats->expr_filter_ns);
+ DCHECK(_remaining_vconjunct_root != nullptr);
+ DCHECK(block->rows() != 0);
+ // LOG(INFO) << "_execute_remaining_expr 000 block: " <<
block->each_col_size();
+ // LOG(INFO) << "_execute_remaining_expr 111 block: " <<
_remaining_vconjunct_root->debug_string();
+ size_t prev_columns = block->columns();
+ int result_column_id = -1;
+ execute_remaining_exp_num++;
+ // LOG(INFO) << "_execute_remaining_expr 777 block: " <<
block->each_col_size() << ", result_column_id " << result_column_id
+ // // << ", dump_data " << block->dump_data(0, 1)
+ // << ", conjunct root: " <<
_remaining_vconjunct_root->debug_string()
+ // << ", child size: " <<
_remaining_vconjunct_root->children().size()
+ // << ", execute_remaining_exp_num " <<
execute_remaining_exp_num
+ // << " block->rows() " << block->rows();
+ RETURN_IF_ERROR(_remaining_vconjunct_ctx->execute(block,
&result_column_id));
+ vectorized::ColumnPtr filter_column =
block->get_by_position(result_column_id).column;
+ if (auto* nullable_column =
+
vectorized::check_and_get_column<vectorized::ColumnNullable>(*filter_column)) {
+ // LOG(INFO) << "_execute_remaining_expr 111";
+ vectorized::ColumnPtr nested_column =
nullable_column->get_nested_column_ptr();
+
+ vectorized::MutableColumnPtr mutable_holder =
+ nested_column->use_count() == 1
+ ? nested_column->assume_mutable()
+ : nested_column->clone_resized(nested_column->size());
+
+ vectorized::ColumnUInt8* concrete_column =
+ typeid_cast<vectorized::ColumnUInt8*>(mutable_holder.get());
+ if (!concrete_column) {
+ return Status::InvalidArgument(
+ "Illegal type {} of column for filter. Must be UInt8 or
Nullable(UInt8).",
+ filter_column->get_name());
+ }
+ auto* __restrict null_map =
nullable_column->get_null_map_data().data();
+ vectorized::IColumn::Filter& filter = concrete_column->get_data();
+ auto* __restrict filter_data = filter.data();
+
+ const size_t size = filter.size();
+ for (size_t i = 0; i < size; ++i) {
+ filter_data[i] &= !null_map[i];
+ }
+
+ selected_size = _evaluate_remaining_expr_filter(sel_rowid_idx,
selected_size, filter);
+ vectorized::Block::filter_block_internal(block, _columns_to_filter,
filter);
+ } else if (auto* const_column =
+
vectorized::check_and_get_column<vectorized::ColumnConst>(*filter_column)) {
+ // LOG(INFO) << "_execute_remaining_expr 222";
+ bool ret = const_column->get_bool(0);
Review Comment:
warning: std::move of the const expression has no effect; remove std::move()
[performance-move-const-arg]
```suggestion
*block->get_by_position(col).column.assume_mutable()->clear();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
