shuke987 opened a new pull request, #68556: URL: https://github.com/apache/doris/pull/68556
### What problem does this PR solve? Related PR: #68547 Problem Summary: Reviews check out the PR head, but the shared workflow requires a repository `code-review` skill before any code inspection. Older release heads do not contain that skill. The review of #66227 (targeting `branch-4.1`) therefore exhausted its goal turns without inspecting the diff or submitting a review, even with the working Codex runtime. For PRs targeting `branch-4.2`, `branch-4.1`, or `branch-4.0` whose checkout lacks the skill, prepare the skill and its referenced module guides from the immutable workflow commit. Store them under the per-run review context and rewrite the skill's guide paths to resolve to existing branch guides or the prepared copies. Keep existing branch guides and skills intact and give every review agent the explicit skill path. Preserve the current behavior for other target branches. Record the source SHA/path mapping and fail context preparation if trusted instructions are incomplete. Branch code and branch-specific guides take precedence over supplemental guidance from the workflow version. This is a shared-workflow fix on master: after merge, newly triggered reviews for all three target branches receive it without updating their PR heads or cherry-picking documentation. ### Release note None ### Check List (For Author) - Test: 8 focused Python unittest tests passed, including actual workflow context/prompt shell execution with mocked GitHub HTTP, exact-SHA fetching, missing dependencies, branch scope, and existing-guide preservation. - Manual validation: all 18 module-guide references resolve for actual `branch-4.2`, `branch-4.1`, `branch-4.0` snapshots and the failed #66227 head (`6009fdb795a151e4529a4a15578046a1b87178be`); original guide contents are unchanged. #66227 retains its required format_v2 and thirdparty guides. - Syntax: workflow YAML parsing, `bash -n` for both modified shell steps, and `git diff --check` passed. - Behavior changed: Yes, missing review instructions are supplied for the three named release branches. No product runtime change. - Does this need documentation: No; the workflow prompt and source manifest describe the generated guidance. - Production review verification: pending merge and a new review run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
