Gabriel39 commented on PR #68568:
URL: https://github.com/apache/doris/pull/68568#issuecomment-5870326007
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68568
commit: d58c0e1027e41b04b7469346c02293ee8aeafe76
base: 388e935b06afb85b93cb032ad0acb160ce2c6059
reviewed_at: 2026-09-28T20:57+08:00
reviewer: Gabriel39
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `fe/fe-core/src/main/java/org/apache/iceberg/DorisDataTableScan.java:51` —
Rechecked that rebinding includes the selected snapshot's data and delete specs
while excluding unrelated later specs that conflict with historical names.
-
`fe/fe-core/src/test/java/org/apache/doris/datasource/iceberg/source/IcebergScanNodeTest.java:3232`
— The selected snapshot contains a nonmatching manifest; exact task and
batch-threshold assertions now verify pruning.
-
`regression-test/suites/external_table_p0/iceberg/test_iceberg_historical_filter_planning.groovy:80`
— Positive cache activity and zero failures now expose SDK fallback. This
review inspected source and pinned Iceberg 1.11.0 dependencies; it did not run
builds or tests.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
