shuke987 opened a new pull request, #68599:
URL: https://github.com/apache/doris/pull/68599
### What problem does this PR solve?
Issue Number: N/A
Related PR: #68567
Problem Summary:
The review of #66227 in run 36422537817 submitted and verified review
5339520198 with one P1 finding, then hit model capacity during wrap-up. The
runner waited five minutes and failed its duplicate-review guard. The
existing status publisher also treated any successful execution as a passing
review without considering P0/P1 findings.
Declare the complete final review through a trusted helper loaded from the
workflow SHA. Bind its summary, full inline set, and reconfirmed existing
blockers to a per-invocation marker and target head. Independently verify
GitHub delivery before accepting completion, including after a terminal
capacity error. Read back ambiguous submissions without reposting. Preserve
failure for incomplete, foreign, stale, cancelled, or unverifiable work.
Separate execution completion from the PR verdict: completed P0/P1 reviews
block code-review, while completed reviews without P0/P1 pass. Keep
authorized
local PASS/skip overrides. Retain the real failed model turn in telemetry and
record verified completion separately. Six five-minute retries remain for
unfinished capacity failures.
### Release note
None
### Check List (For Author)
- Test: Python unit and workflow-shell integration tests on macOS and native
Linux; complete Linux suite has 158 tests, with no skips. YAML parsing,
bash syntax validation for all 27 runner shell blocks, and git diff
--check.
- Behavior changed: Yes. A verified final review survives wrap-up capacity;
P0/P1 findings set the review status to failure without failing execution.
- Does this need documentation: No. The workflow prompt documents the final
submission contract. Changes are internal to review CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
