Gabriel39 opened a new pull request, #68603:
URL: https://github.com/apache/doris/pull/68603
### What problem does this PR solve?
Related PR: #68532
Port the merged branch-4.1 change to master. External binary columns retain
VARBINARY, and instant-bearing timestamp columns retain TIMESTAMPTZ instead of
silently becoming text or local wall-clock values. This includes SQL/view
handling, JDBC read/write normalization, Iceberg partition transforms and
commit metadata, and the matching regression expectations.
Master has moved external catalogs into connector plugins and JDBC execution
into type handlers. The port applies the changes to those implementations and
preserves master-specific behavior, including typed predicate pushdown and
write planning. It adds tests for connector mappings, UTC carriers, negative
timestamps, historical Paimon ORC schemas, and static partition NULL/binary
serialization.
Paimon write support has not been migrated to master's connector
architecture. The legacy Paimon FE writer and its deleted write suites are not
restored; Paimon read/type-mapping and legacy-ORC fallback changes are included.
### Release note
External binary and instant timestamp mappings are enabled regardless of the
deprecated catalog toggles. Ordinary views can preserve VARBINARY; native
materialization restrictions remain. File TVF binary mapping remains explicit,
while annotated instant timestamps map to TIMESTAMPTZ.
### Check List (For Author)
- Test:
- [x] Unit Test: connector mapping/planning and JNI reader/writer
suites; targeted FE core tests.
- [x] Regression test: ported suites and expected results; 46 changed
Groovy suites parsed locally. External service-backed execution is pending CI.
- [ ] Manual test
- Behavior changed:
- [x] Yes, as described above and in #68532.
- Does this need documentation?
- [x] No additional documentation beyond the source PR's mapping change.
Validation:
- 54 targeted FE core tests and 78 targeted BE ASAN tests passed. The local
BE test build selected relevant translation units and shared utilities; the
original CMake configuration was restored afterward.
- Connector and JNI suites passed after disabling Maven build caching,
including Paimon packaging. Five existing tests were skipped by their
conditions. External database-backed regression and opt-in JDBC integration
tests remain for CI.
- Full BE build, FE Checkstyle, clang-format 16 for all 16 changed C++
files, and BE header hygiene passed.
- The broader Iceberg run exposed
`IcebergWritePlanProviderTest.planMergePreservesExplicitlyEmptyReadAcrossConcurrentFirstAppend`
expecting null instead of -1. It also fails with the unchanged master
provider, so it is excluded from the passing suite and left unchanged.
- clang-tidy could not complete because of baseline `types.h` NOLINT
diagnostics and the local toolchain's `stddef.h` lookup failure. No clang-tidy
pass is claimed.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
