hubgeter opened a new pull request, #417: URL: https://github.com/apache/doris-thirdparty/pull/417
`ZlibDecompressionStreamByLibDeflate` was only compiled and selected on x86, so on AArch64 ORC ZLIB streams fell back to the zlib `inflate` path (`ZlibDecompressionStream`). libdeflate is already built for every platform by Doris' `build-thirdparty.sh` and ships in the linux x86_64 and aarch64 prebuilt packages, so this removes the architecture guards and always decodes ZLIB chunks with `libdeflate_deflate_decompress`. x86 behavior is unchanged. Tests: adds `Compression.zlib_malformed_chunks`, which checks that a malformed ZLIB chunk raises `ParseError`: - decompressed chunk larger than the block buffer - chunk header longer than the stream - truncated deflate payload - reserved deflate block type The existing ZLIB tests in `TestCompression.cc` keep passing. They run as part of Doris `doris_be_test`. StarRocks made the same change in StarRocks/starrocks#78457 and reports 583 MB/s → 2678 MB/s (4.57x) ZLIB/GZIP decompression throughput on Neoverse-N1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
