924060929 commented on code in PR #68196:
URL: https://github.com/apache/doris/pull/68196#discussion_r4130204438


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java:
##########
@@ -1075,8 +1107,14 @@ public void addExternalPartitions(String catalogName, 
String dbName, String tabl
         if (!(catalog instanceof ExternalCatalog)) {
             throw new DdlException("Only support ExternalCatalog");
         }
+        // Partition events are already committed remotely. Fence the row 
count by cached identity
+        // before any database/table reload can fail and make the 
ignored-not-found path return.
+        Env.getCurrentEnv().getExtMetaCacheMgr()
+                .invalidateRowCountCache(catalog.getId(), dbName, tableName);
         DatabaseIf db = catalog.getDbNullable(dbName);

Review Comment:
   Fixed in 182ef43447a. HMS now checks the catalog database and include-table 
filters before any row-count or engine-cache invalidation. All three 
notification routes are covered: add/drop partition in CatalogMgr and 
alter-partition refresh in RefreshManager. CatalogMgrTest exercises excluded 
ARCHIVED.t and sales.cold alongside an included sales.hot target and verifies 
no cache-manager interaction for the excluded events. The 176 focused FE tests 
and full FE build pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to