yujun777 commented on PR #68662: URL: https://github.com/apache/doris/pull/68662#issuecomment-5907297751
The remaining windows this PR does not fix -- the FE stopping between the two halves (crash, master switch), a `replacePartition` that throws, a remote commit whose reply is lost, and a cloud transaction that the meta service reports as failed after a maybe-commit -- are now tracked in #68679, together with the owner-side decision a cancellation needs for a remote target. The fix directions there are the ones this PR's scope note names: making the publication a committed action of the insert transaction (or moving the consumption position into the publication's record). This PR stays on what it fixed: a cancellation that found nothing committed fails the statement, one that reaches the swap under its lock is still honoured, one over committed rows completes the swap, and an error response over committed rows (the session's visibility-timeout mode) publishes them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
