github-actions[bot] commented on code in PR #16635:
URL: https://github.com/apache/doris/pull/16635#discussion_r1103620629


##########
be/src/service/internal_service.cpp:
##########
@@ -1072,14 +1178,22 @@ void 
PInternalServiceImpl::multiget_data(google::protobuf::RpcController* contro
                                          const PMultiGetRequest* request,
                                          PMultiGetResponse* response,
                                          google::protobuf::Closure* done) {
-    // multi get data by rowid
-    MonotonicStopWatch watch;
-    watch.start();
-    brpc::ClosureGuard closure_guard(done);
-    response->mutable_status()->set_status_code(0);
-    Status st = _multi_get(request, response);
-    st.to_protobuf(response->mutable_status());
-    LOG(INFO) << "multiget_data finished, cost(us):" << watch.elapsed_time() / 
1000;
+    // Submit task to seperate ThreadPool for avoiding block bthread working 
pthread
+    ThreadPool* task_pool = 
StorageEngine::instance()->get_bg_multiget_threadpool();

Review Comment:
   warning: no member named 'get_bg_multiget_threadpool' in 
'doris::StorageEngine' [clang-diagnostic-error]
   ```cpp
       ThreadPool* task_pool = 
StorageEngine::instance()->get_bg_multiget_threadpool();
                                                          ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to