u70b3 commented on code in PR #67978:
URL: https://github.com/apache/doris/pull/67978#discussion_r4144162145
##########
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java:
##########
@@ -1145,6 +1147,23 @@ public TMasterResult finishTask(TFinishTaskRequest
request) throws TException {
return masterImpl.finishTask(request);
}
+ /**
+ * Typed result envelope of one Lance index mutation invocation. Stale or
+ * identity-mismatched reports are logged and dropped; a complete matched
+ * report is classified into the durable job state. This layer stays thin:
+ * only the master accepts reports, and everything beyond identity checking
+ * and classification lives in the report handler.
+ */
+ @Override
+ public TStatus reportLanceIndexJobResult(TLanceIndexJobReport report)
throws TException {
Review Comment:
done, each dispatch now mints a 128-bit random secret that travels only in
the dispatch request and its report echo; the handler drops any report without
a constant-time secret match — including its CHILD_REAPED proof — before the
manager is touched, the secret is journaled but never shown or logged, and SHOW
keeps only the now non-authorizing identity fields (a87d7350f)
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -4276,4 +4276,64 @@ public void handle(Field field, String value) throws
Exception {
"Static upper bound for num_sub_vectors of Lance IVF_PQ
indexes."})
public static int lance_index_max_num_sub_vectors = 256;
+ @ConfField(mutable = true, masterOnly = true,
+ callback =
LanceIndexConfigValidator.PositiveIntConfigHandler.class,
+ description = {"Lance 索引 job 派发器(含 deadline/possible-live 扫掠与
refresh 驱动)的轮询周期(秒)。",
+ "Polling interval in seconds of the Lance index job
dispatcher "
+ + "(dispatch sweep, deadline/possible-live sweeps, and
refresh driver)."})
+ public static int lance_index_job_dispatch_interval_second = 10;
Review Comment:
done, all five numeric dispatcher settings are now volatile, so an ADMIN SET
write is published to the daemon thread without the ConfigBase monitor
(60a1051ae)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
