morningman commented on code in PR #16036:
URL: https://github.com/apache/doris/pull/16036#discussion_r1103753667
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionInfo.java:
##########
@@ -76,13 +76,16 @@ public class PartitionInfo implements Writable {
// so we defer adding meta serialization until memory engine feature is
more complete.
protected Map<Long, TTabletType> idToTabletType;
+ protected Map<Long /* partition id */, Boolean /* mutable */> idToMutable;
Review Comment:
You can add this new properties in `DataProperty`
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -1004,6 +1004,23 @@ Status VOlapTableSink::find_tablet(RuntimeState* state,
vectorized::Block* block
is_continue = true;
return status;
}
+ if (!(*partition)->is_mutable) {
+ RETURN_IF_ERROR(state->append_error_msg_to_file(
+ []() -> std::string { return ""; },
+ [&]() -> std::string {
+ fmt::memory_buffer buf;
+ fmt::format_to(buf, "partition immutable for this tuple.
tuple={}",
Review Comment:
And if you call `append_error_msg_to_file`, it may return `stop_processing`
to true, and stop the load job.
But in your design, these rows should be `unselected rows`, and should not
stop the job
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -1004,6 +1004,23 @@ Status VOlapTableSink::find_tablet(RuntimeState* state,
vectorized::Block* block
is_continue = true;
return status;
}
+ if (!(*partition)->is_mutable) {
+ RETURN_IF_ERROR(state->append_error_msg_to_file(
+ []() -> std::string { return ""; },
+ [&]() -> std::string {
+ fmt::memory_buffer buf;
+ fmt::format_to(buf, "partition immutable for this tuple.
tuple={}",
Review Comment:
```suggestion
fmt::format_to(buf, "partition is immutable for this
tuple. tuple={}",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
