HappenLee commented on PR #68672: URL: https://github.com/apache/doris/pull/68672#issuecomment-5949468597
/review Please re-review the updated head `d78bb71e44213a9341a1d4d50afa15d2e32db99b`. The two remaining supported-path P1 findings are fixed: - Recursively classify TIME-to-date conversions in ARRAY/MAP/STRUCT casts, preserving known-NULL folding and cast legality checks. - Check runtime-filter target expressions and implicit probe casts in both singleton and grouped translation, including grouped targets with differing expressions. Never reenable a previously ineligible scan. For the upgrade finding: the owner confirmed new FE/old BE does not occur under the supported BE-before-FE upgrade procedure. The direct reply is https://github.com/apache/doris/pull/68672#discussion_r4164416865 . Old FE/new BE continues to default the optional flag to false. Please assess compatibility against this supported sequence. Validation: both bugs reproduced in added tests before the fix; 102 FE unit tests and FE build/Checkstyle passed. The condition-cache regression passed output generation and independent verification, including zero BE lookups for nested casts and repeated RF-probe joins. Deterministic ConditionCacheHit=1, ConditionCacheFilteredRows=79872. TIME-cast and array-literal regression suites also passed. Runtime/build environment details are in the updated PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
