morningman commented on PR #68710:
URL: https://github.com/apache/doris/pull/68710#issuecomment-5987481758
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68710
commit: b9d817e992d8c25937a905416924e2f9c2d35a5c
base: 0dcd2a31a7bb00ba9a817c2600f64e770efea54d
reviewed_at: 2026-10-05T11:16+08:00
reviewer: morningman
model: claude-opus-5-5[1m]
effort: max
findings: {blocker: 0, major: 0, minor: 1, nit: 5}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-01 (Minor, maintainability)
`fe/be-java-extensions/fluss-client-patch/pom.xml:61-65` — nothing ties the
copies
to `fluss.version` / `paimon.version`. A bump that changes
`ShutdownableThread` (upstream added `pause()` on
2026-09-11, apache/fluss ee584f8992) compiles and passes the tests; a
member missing inside `doWork()` would be
absorbed by the copy's `catch (Error e)` as a silent remote-read hang. A
reflective parity test against the
library's own class, plus a pointer in the two version comments in
`fe/pom.xml`, would catch it.
- F-02 (Nit) `fe/be-java-extensions/fluss-scanner/pom.xml:77-87` — narrowing
the patch dependency to provided/test
would drop the jar from `plugins/jni` with every gate green (the
hadoop-deps shadow has the same gap); a
per-plugin required-shadows table in
`tools/be-java-plugins/check_plugin_layout.py` would close it.
- F-03/F-04 (Nits) — the death tests report a lost copy only as a crashed
surefire fork; a `@BeforeAll`
code-source check and an `isShutdownInitiated()` assertion would make them
fail with a message.
- Checked against the pinned artifacts (fluss-client 1.0.0, paimon 1.3.1):
the copies are member-for-member
identical, there is no other thread-death exit path in either library, and
the `ShutdownableThread` copy
differs from fluss's only on the four paths the PR body declares.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
