morningman commented on PR #68743:
URL: https://github.com/apache/doris/pull/68743#issuecomment-6013920486
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68743
commit: ed7ce0b407ad1e7bc7d7030ee5ee5be91e9b11ad
base: 7ac0eb2fdb426595f810e94ab77b7aa2eece12d5
reviewed_at: 2026-10-06T18:03+08:00
reviewer: morningman
model: claude-opus-5-5[1m]
effort: max
findings: {blocker: 0, major: 0, minor: 0, nit: 2}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-01 (Nit, wording)
`fe/fe-core/src/main/java/org/apache/doris/qe/ResultReceiver.java:166-171`: the
hook comment says only a session's own query can take the hit, but the filter
tests the per-connection `QueryState.isInternal` flag, which is never reset. A
session that ran `SHOW TABLE STATUS` or `SHOW ... WHERE` can never take it, and
an export task can. Rewording the comment and the UT javadoc is enough; this
PR's own suite is not affected.
- F-02 (Nit, test-coverage, carried from the review of `ca93951`)
`fe/fe-core/src/test/java/org/apache/doris/datasource/scan/PluginDrivenScanNodeRedispatchTest.java:66-78`:
the UT reaches `toSplit` only by reflection, so no test guards the two batch
split sites in `PluginDrivenScanNode`.
- The previous head's Blocker (the new suite failed in External, whose FE
had debug points off) and Minor (auto-analyze could spend the one-shot debug
point) are fixed by `ed7ce0b`. This was checked statically against the External
setup. The External build for this head (1062346) was still queued when the
review finished, so the suite's first CI execution there is still pending.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
