github-actions[bot] commented on code in PR #65684:
URL: https://github.com/apache/doris/pull/65684#discussion_r4218291253
##########
be/src/storage/iterators.h:
##########
@@ -45,6 +45,13 @@ struct IteratorRowRef;
class StorageReadOptions {
public:
+ // Every storage read needs a statistics sink. Deleting the default
constructor keeps copied
+ // options valid from creation; for example, SegmentIterator stores a copy
and later
+ // dereferences stats while reading pages.
+ StorageReadOptions() = delete;
Review Comment:
[P2] Update the benchmark caller for the required statistics argument.
`benchmark_variant_segment.hpp:1282` still declares `StorageReadOptions
options;`, but this deleted constructor is used when `benchmark_main.cpp`
includes that header for `BUILD_BENCHMARK=ON`. The optional `benchmark_test`
target cannot compile. Construct it with the existing `stats` object and remove
the later `options.stats` assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
