github-actions[bot] commented on code in PR #16383:
URL: https://github.com/apache/doris/pull/16383#discussion_r1104251108
##########
be/src/vec/sink/vdata_stream_sender.h:
##########
@@ -392,14 +392,32 @@ Status VDataStreamSender::channel_add_rows(Channels&
channels, int num_channels,
return Status::OK();
}
-class PipChannel : public Channel {
+class PipChannel final : public Channel {
public:
PipChannel(VDataStreamSender* parent, const RowDescriptor& row_desc,
const TNetworkAddress& brpc_dest, const TUniqueId&
fragment_instance_id,
PlanNodeId dest_node_id, int buffer_size, bool
is_transfer_chain,
bool send_query_statistics_with_every_batch)
: Channel(parent, row_desc, brpc_dest, fragment_instance_id,
dest_node_id, buffer_size,
- is_transfer_chain,
send_query_statistics_with_every_batch) {}
+ is_transfer_chain,
send_query_statistics_with_every_batch) {
+ ch_roll_pb_block();
+ }
+
+ ~PipChannel() {
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
~PipChannel() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
