jacktengg commented on PR #68455:
URL: https://github.com/apache/doris/pull/68455#issuecomment-6072726672
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68455
commit: f8aee54b2474af45357a6a7ebe2c481ef45a4d74
base: 288e89103d58f531739c93328f63c3f497fcd3c1
reviewed_at: 2026-10-09T10:01+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- No new findings after deduplication; all 11 changed files were covered by
two qualified reviewers. Builds and tests were not run during this read-only
review.
- `be/src/exec/operator/analytic_sink_operator.cpp:230` — The existing [P1
thread](https://github.com/apache/doris/pull/68455#discussion_r4089152052)
still covers old-FE input reaching unchanged BE arithmetic during rolling
upgrades. New FE rejects the direct huge ROWS example, but this receipt does
not declare the old-FE concern resolved.
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/WindowFunctionChecker.java:237`
— The already reported [safe 64-bit PRECEDING
concern](https://github.com/apache/doris/pull/68455#discussion_r4091103028)
remains acknowledged. It was excluded as a duplicate, not dismissed as
incorrect.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
