mrhhsg commented on code in PR #68579:
URL: https://github.com/apache/doris/pull/68579#discussion_r4229045951
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/OrthogonalBitmapExprCalculate.java:
##########
@@ -64,6 +64,14 @@ private
OrthogonalBitmapExprCalculate(AggregateFunctionParams functionParams) {
super(functionParams);
}
+ @Override
+ public void checkLegalityBeforeTypeCoercion() {
+ if (!getArgument(2).isConstant()) {
+ throw new AnalysisException("The third argument of " + getName()
Review Comment:
Fixed in 912dc0233e2. Both orthogonal bitmap expression variants reject a
NULL formula during FE analysis and after rewrite. The BE nullable aggregate
wrapper also validates a nullable formula before it can skip rows, covering
constant expressions evaluated only in BE. FE UT, BE UT, and focused SQL
regressions cover NULL and non-NULL nullable formulas.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/SequenceFunction.java:
##########
@@ -34,17 +35,43 @@ public interface SequenceFunction extends FunctionTrait {
default void checkLegalityBeforeTypeCoercion() {
String functionName = getName();
Expression firstArg = getArgument(0);
- if (!(firstArg instanceof StringLikeLiteral)) {
Review Comment:
Fixed earlier in ec68ca44d64. Both sequence variants reject a typed NULL
pattern after constant folding; the FE unit test and fold_literal_arguments
regression cover it and passed again with the current head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
