liaoxin01 commented on code in PR #67759:
URL: https://github.com/apache/doris/pull/67759#discussion_r4230372865
##########
be/src/load/delta_writer/delta_writer.cpp:
##########
@@ -97,8 +97,14 @@ BaseDeltaWriter::~BaseDeltaWriter() {
return;
}
- // cancel and wait all memtables in flush queue to be finished
+ // Stop flush producers before releasing their rowset builders.
static_cast<void>(_memtable_writer->cancel());
+ // Close may observe cancellation after submitting bitmap work. Drain that
+ // work before derived builders roll back transactions or clear rowset
caches.
+ if (_req.load_cancel_status && !_req.load_cancel_status->ok()) {
+ WARN_IF_ERROR(_rowset_builder->wait_calc_delete_bitmap(),
Review Comment:
we shouldn't wait the delete bitmap here，just cancel it？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
