OIiveirra commented on code in PR #68726:
URL: https://github.com/apache/doris/pull/68726#discussion_r4231634003
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1301,6 +1316,37 @@ public PlanFragment visitPhysicalHashAggregate(
return inputPlanFragment;
}
+ /** Match only row-count aggregates over an unfiltered external file TVF.
*/
+ static Optional<PhysicalTVFRelation> countPushDownFileTvf(
+ PhysicalHashAggregate<? extends Plan> aggregate, SessionVariable
sessionVariable) {
+ Plan child = aggregate.child(0);
+ Plan tvfChild = child instanceof PhysicalProject && child.child(0)
instanceof PhysicalTVFRelation
Review Comment:
Fixed in 0be73f90a5f.
COUNT pushdown now rejects a PhysicalProject when any direct or multi-layer
project expression contains NoneMovableFunction, so retained assertions
continue to run against real file values. Added FE coverage for direct and
multi-layer projects, plus Parquet/ORC regressions covering scanner V1/V2 and
pushdown enabled/disabled cases. FileTvfCountPushDownTest passes 5/5 and Maven
checkstyle passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
