lets-order-some-fries commented on PR #67238:
URL: https://github.com/apache/doris/pull/67238#issuecomment-6084405229
Update since my note on 22 Sep: fe-core now builds on my machine, so this is
no longer locally untested. On `990882a3`, `DiffFunctionSignatureTest` passes
5/5 and fe-core checkstyle is clean.
The automated review's two cases:
1. zoned + zone-less literal (`hours_diff('2021-03-14 03:30:00-07:00',
'2021-03-14 01:30:00')`): fixed in `a6591567`, pinned by
`testMixedZonedAndZonelessLiteralsKeepTimeStampTz`.
2. compact + colon offset (`'2021-03-15 00:00:00-0700'` with `'2021-03-14
00:00:00-08:00'`): pinned by `testCompactAndColonOffsetLiteralsKeepTimeStampTz`
in `990882a3`, both argument orders.
Both fail if the `SearchSignature` change is reverted. One thing this PR
does not change: `DateTimeChecker.hasTimeZone` does not accept a compact offset
like `-0700` on its own, so a call whose only zone is compact still binds
DATETIMEV2, as on master. Aligning it with the cast grammar would be a separate
change; happy to follow up if you want it.
@924060929 could you run `/review` and `run buildall` on `990882a3` when you
have time? CI has not built this head yet, and I'll fix anything it turns up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
