zhangstar333 commented on code in PR #68813:
URL: https://github.com/apache/doris/pull/68813#discussion_r4227908355
##########
be/src/format_v2/table/lance_reader.cpp:
##########
@@ -1180,7 +1066,8 @@ void LanceTableReader::_collect_scan_statistics(void*
callback_ctx, const void*
update_counter(reader->_execution_iops, statistics->iops, "iops");
update_counter(reader->_execution_requests, statistics->requests,
"requests");
update_counter(reader->_execution_bytes_read, statistics->bytes_read,
"bytes_read");
- update_counter(reader->_index_partition_cache_miss_loads,
statistics->index_partitions_loaded,
+ update_counter(reader->_index_object_loads, statistics->indices_loaded,
"indices_loaded");
+ update_counter(reader->_index_components_loaded,
statistics->index_partitions_loaded,
"index_partitions_loaded");
update_counter(reader->_index_comparisons, statistics->index_comparisons,
"index_comparisons");
Review Comment:
done
##########
thirdparty/patches/lance-c-foyer.patch:
##########
@@ -1003,32 +7293,20 @@ index
0000000000000000000000000000000000000000..cfc47f1528d11b6be068c09dd4703ff4
+ },
+ )
+ .await?;
-+ // HTTP responses carry transport extensions even for immutable
files.
-+ // Cache metadata independently; request-specific extensions are
never replayed.
++ // Cache only immutable metadata and attributes, never
request-specific state.
+ self.reader.cache.metadata.insert(
-+ metadata_key.clone(),
++ metadata_key,
+ (result.meta.clone(), result.attributes.clone()),
+ );
-+ (result.meta, result.attributes, result.extensions)
++ (result.meta, result.attributes)
+ };
+ let object_size = metadata.size;
-+ let size_bytes = object_size.to_le_bytes();
-+ // WriteOnInsertion enqueues disk I/O even for an identical value.
Look in
-+ // both tiers so warm reads, including recovered entries, remain
read-only.
Review Comment:
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
