github-actions[bot] commented on code in PR #67409:
URL: https://github.com/apache/doris/pull/67409#discussion_r4228113949
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/HttpStreamTableValuedFunction.java:
##########
@@ -40,6 +40,10 @@ public HttpStreamTableValuedFunction(Map<String, String>
properties) throws Anal
// 1. analyze common properties
super.parseCommonProperties(properties);
+ if (!getPathPartitionKeys().isEmpty()) {
Review Comment:
[P3] Reject a supplied `path_partition_keys` property even when parsing
yields no keys. `parseCommonProperties` removes the property and uses
`String.split(",")`, which drops trailing empty fields. For
`path_partition_keys=","`, the parsed list is empty, so this guard accepts the
unsupported option and an otherwise valid SQL stream load proceeds instead of
returning the analysis error. Check property presence before it is consumed,
including resource properties, and add a negative test for this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
