morningman commented on code in PR #68797:
URL: https://github.com/apache/doris/pull/68797#discussion_r4231377595
##########
be/src/common/config.cpp:
##########
@@ -1228,7 +1228,7 @@ DEFINE_Validator(variant_storage_parse_mode,
[](const int config) -> bool { return config >= 0 && config
<= 2; });
// block file cache
-DEFINE_Bool(enable_file_cache, "false");
+DEFINE_Bool(enable_file_cache, "true");
Review Comment:
Fixed in 0b2a2f26c41. `init_file_cache_factory` now runs
`validate_hdfs_write_batch_buffer_size` first. It rejects a nonpositive
`file_cache_each_block_size` ("file_cache_each_block_size 0 must be positive"),
so the `s3_write_buffer_size % file_cache_each_block_size` check below can no
longer divide by zero. Valid configurations go through the same checks as
before, only in a different order.
`HdfsFileSystemTest.RejectsCacheBlockSizeNotDividingHdfsBatch` now also covers
block sizes 0 and -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
