jacktengg opened a new pull request, #68845:
URL: https://github.com/apache/doris/pull/68845
Issue Number: None
Related PR: None
Problem Summary: topn_array accepts TIMEV2 in its FE signature, but the BE
creator omitted TYPE_TIMEV2, so aggregating CAST('01:00:00' AS TIME) values
failed with an INTERNAL_ERROR while the DATETIMEV2 control succeeded. Register
TIMEV2 through the existing typed TopN implementation and remove the FE
rejection added by the preceding fix. Both argument forms now return time
arrays with the input precision, using the existing frequency ranking, nullable
handling and serialized-state merge logic. Add FE type tests, BE aggregate
tests and regression coverage for precision, negative and large times,
DISTINCT, grouping, state merging, NULL and empty inputs, with DATETIMEV2
controls.
topn_array now supports TIME/TIMEV2 values in both argument forms and
preserves fractional-second precision in its returned arrays.
- Test: ASAN BE and FE build via build.sh --be --fe; FE Checkstyle;
clang-format 16 and format check; BE header hygiene; clang-tidy for the
implementation and new unit test; 2 FE unit tests; 14 TopN BE unit tests
(including 3 TIMEV2 tests); 3 regression suites (topn_array_timev2, topn,
topn_boolean), with 22 generated TIMEV2 regression result checks; original TIME
and DATETIMEV2 SQL reproductions.
- Regression test / Unit Test / Manual test
- Behavior changed: Yes; TIME/TIMEV2 inputs now execute successfully instead
of being rejected or failing with INTERNAL_ERROR.
- Does this need documentation: No; correct the type support already
accepted by the function signature.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
