github-actions[bot] commented on code in PR #68865:
URL: https://github.com/apache/doris/pull/68865#discussion_r4236665637
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/TimeUtils.java:
##########
@@ -142,6 +142,11 @@ public static ZoneId getDorisZoneId() {
return getTimeZone().toZoneId();
}
+ /** Resolve a Doris time-zone name to the canonical ID understood by
execution backends. */
+ public static String getCanonicalTimeZone(String timeZone) {
+ return ZoneId.of(timeZone, timeZoneAliasMap).getId();
Review Comment:
[P1] Keep zero offsets in a BE-readable form. `+00:00`/`-00:00` become `Z`,
and `GMT+00:00`/`GMT-00:00` become bare `GMT` here. BE resolves those IDs only
when `TZDIR` contains the optional `Zulu`/`GMT` files; a valid zone directory
with `UTC` but neither file leaves them unresolved. A merge-on-write partial
update with an omitted `CURRENT_TIMESTAMP` or `CURRENT_DATE` column then
records an empty default after `from_unixtime` fails, and materialization
returns a date parse error. Map both zero-offset outputs to `UTC` (or `+00:00`)
and test these inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
