github-actions[bot] commented on code in PR #68854:
URL: https://github.com/apache/doris/pull/68854#discussion_r4236843634
##########
regression-test/suites/external_table_p0/hive/ddl/test_hive_ddl.groovy:
##########
@@ -419,6 +419,27 @@ suite("test_hive_ddl", "p0,external") {
}
}
+ // GZIP used to be rejected by the Doris Parquet writer with
+ // "Unsupported compress type GZ with parquet"; the write must
succeed and land on the
+ // GZIP Parquet codec. Asserted instead of `qt_` because the
expectation is one codec name.
+ if (file_format.equals("parquet") && compression.equals("gzip")) {
+ sql """ INSERT INTO tbl_${file_format}_${compression} VALUES
('doris_gzip') """
+ def gzipRows = sql """ SELECT * FROM
tbl_${file_format}_${compression} ORDER BY col """
+ assertEquals(1, gzipRows.size())
+ assertEquals("doris_gzip", gzipRows[0][0].toString())
+ String hdfsPort =
context.config.otherConfigs.get("hive2HdfsPort")
+ String externalEnvIp =
context.config.otherConfigs.get("externalEnvIp")
+ def gzipCodec = sql """
+ SELECT DISTINCT compression
+ FROM parquet_meta(
+ "uri" =
"hdfs://${externalEnvIp}:${hdfsPort}/user/hive/warehouse/test_hive_compress.db/tbl_parquet_gzip/*",
+ "hadoop.username" = "doris",
+ "mode" = "parquet_metadata"
+ )
+ """
+ assertEquals("GZIP", gzipCodec[0][0].toString().toUpperCase())
Review Comment:
[P3] Record deterministic GZIP query results in generated .out files
These new row and footer checks use assertEquals for fixed SQL results, but
the repository's regression-test standard requires qt/order_qt cases with .out
generated by the test runner. The neighboring LZ4 codec checks already use that
pattern. Please convert this Hive GZIP check and the new Iceberg GZIP
row/footer checks to recorded queries, with ORDER BY where needed, and generate
their expected outputs through the regression script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
