robll-v1 commented on PR #68814: URL: https://github.com/apache/doris/pull/68814#issuecomment-6097661221
Agreed. I removed the BE implementation because `typeof` only needs FE type metadata. A shared post-analysis normalization rule lowers it before constant folding, and the FE translator lowers any remaining call before BE serialization, including calls preserved under short-circuit evaluation. Load mappings use the same normalization path. After rebasing onto `apache/master` at `dd456ab7a894f54c6553415223c6d5c9c7d4e035`, local validation of this change passed: the combined BE+FE build reported zero FE Checkstyle violations, all six focused FE unit tests passed, and `test_typeof` passed both while generating its expected output and in a follow-up run without `-forceGenOut`. The regression covers both folding settings, nested calls, empty/nonempty global aggregates, and invalid aggregate/window/cast expressions. Upstream CI for the updated head remains pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
