HappenLee commented on code in PR #68032:
URL: https://github.com/apache/doris/pull/68032#discussion_r4237318939
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -1908,6 +1909,9 @@ Status
CloudMetaMgr::get_storage_vault_info(StorageVaultInfos* vault_infos, bool
}
*is_vault_mode = resp.enable_storage_vault();
+ if (default_vault_id != nullptr) {
+ *default_vault_id = resp.default_storage_vault_id();
Review Comment:
If we use an automatic fallback when no spill vault is explicitly
configured, I would prefer the S3 vault with the smallest numeric ID. Adding a
new vault would then leave the spill destination unchanged, making the behavior
more predictable and easier to maintain. Choosing the largest ID would switch
the destination whenever a higher-ID S3 vault is added, while following the
default vault would switch it whenever the default is changed. We can keep the
explicit spill-vault configuration for intentional changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
