github-actions[bot] commented on code in PR #68901:
URL: https://github.com/apache/doris/pull/68901#discussion_r4240045704
##########
fe/fe-connector/fe-connector-spi/src/main/java/org/apache/doris/connector/spi/ConnectorStatementScope.java:
##########
@@ -44,6 +44,27 @@ public interface ConnectorStatementScope {
*/
<T> T computeIfAbsent(String key, Supplier<T> loader);
+ /**
+ * {@link #computeIfAbsent} for a value only planning reads, such as a
memo that lets the identical scans of
+ * one plan share their planned ranges. The engine drops such values once
planning ends ({@link #endPlanning}),
+ * so nothing they reference is held while the statement executes. A call
after that computes and registers
+ * the value again, which a scan planned at execution time (a partition
batch planned through
+ * {@code ConnectorScanPlanProvider#planScanForPartitionBatch}'s default)
would do: the value then stays until
+ * {@link #closeAll}. The value must hold nothing to close, because it is
dropped without being closed. Under
+ * {@link #NONE} the loader runs on every call.
+ */
+ default <T> T computeIfAbsentForPlanning(String key, Supplier<T> loader) {
Review Comment:
[P1] Bump the connector plugin API major for this new scope method. All four
updated connector jars invoke `computeIfAbsentForPlanning`, yet
`fe/fe-connector/pom.xml` still stamps API 13.0. An FE built from the base head
also serves 13.0, so it admits one of these directory plugins; its parent-first
`ConnectorStatementScope` lacks this method and a reuse-enabled scan fails with
`NoSuchMethodError`. The unreleased status of 13.0 does not make that mixed
installation safe. Bump the major and pinned test expectation, and add this
interface to the frozen surface baseline so future changes are detected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
