morrySnow commented on code in PR #16459:
URL: https://github.com/apache/doris/pull/16459#discussion_r1105458743
##########
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java:
##########
@@ -539,6 +539,14 @@ private boolean
dataDistributionMatchEqPredicate(List<BinaryPredicate> eqJoinPre
// they are naturally colocate relationship no need to check colocate
group
Collection<Long> leftPartitions = leftRoot.getSelectedPartitionIds();
Collection<Long> rightPartitions = rightRoot.getSelectedPartitionIds();
+
+ // For UT or no partition is selected, getSelectedIndexId() == -1, see
selectMaterializedView()
+ // boolean hitSameIndex = (leftTable.getId() ==
rightTable.getId())
+ // && (leftRoot.getSelectedIndexId() != -1 &&
rightRoot.getSelectedIndexId() != -1)
+ // && (leftRoot.getSelectedIndexId() ==
rightRoot.getSelectedIndexId());
+ //
+ // boolean noNeedCheckColocateGroup = hitSameIndex &&
(leftPartitions.equals(rightPartitions))
+ // && (leftPartitions.size() <= 1);
Review Comment:
mis-comment the new code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
