BiteTheDDDDt commented on code in PR #16734:
URL: https://github.com/apache/doris/pull/16734#discussion_r1105514952
##########
be/src/vec/data_types/data_type_nullable.cpp:
##########
@@ -158,4 +158,16 @@ DataTypePtr remove_nullable(const DataTypePtr& type) {
return type;
}
+DataTypes remove_nullable(const DataTypes& types) {
+ DataTypes no_null_types;
+ for (auto& type : types) {
+ if (type->is_nullable()) {
+ no_null_types.push_back(static_cast<const
DataTypeNullable&>(*type).get_nested_type());
Review Comment:
Maybe we can just use `no_null_types.push_back(remove_nullable(type))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
