github-actions[bot] commented on code in PR #68837:
URL: https://github.com/apache/doris/pull/68837#discussion_r4245758495
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -3805,9 +3824,9 @@ private DataPartition toDataPartition(DistributionSpec
distributionSpec/* target
partitionExprs.add(context.findSlotRef(partitionExprId));
}
}
- return new
DataPartition(TPartitionType.HIVE_TABLE_SINK_HASH_PARTITIONED, partitionExprs);
+ return createHiveTableSinkDataPartition(partitionExprs,
Config.be_exec_version);
Review Comment:
[P1] Pin Hive routing to the execution version sent with this query.
`be_exec_version` is mutable: a parallel Hive INSERT can build enum 10/11 while
it is 16, then `CoordinatorContext.initQueryOptions` can read 13 after an
operator changes the setting. With two or more destination instances, a
branch-4.2 BE accepts version 13 but its exchange sink does not handle enum
10/11; it returns OK without forwarding the block, so the INSERT can commit
missing rows. This differs from the fixed-version case in the existing Thrift
thread. Capture one version for planning and dispatch, or reject a mismatch
before execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
