OIiveirra commented on code in PR #68726:
URL: https://github.com/apache/doris/pull/68726#discussion_r4246465287
##########
fe/fe-core/src/main/java/org/apache/doris/load/StreamLoadHandler.java:
##########
@@ -241,9 +241,17 @@ private void setDbAndTable() throws UserException,
MetaNotFoundException {
if (result != null) {
OlapTable olapTable = tables.get(0);
- result.setDbId(db.getId());
- result.setTableId(olapTable.getId());
- result.setBaseSchemaVersion(olapTable.getBaseSchemaVersion());
+ if (!olapTable.tryReadLock(timeoutMs, TimeUnit.MILLISECONDS)) {
Review Comment:
Thanks for the scope feedback. I verified the origin with a differential
unit test: the unmodified pre-optimization baseline also fails with the same
baseIndexMeta null dereference under concurrent base-index replacement. The
read-lock fix makes that test pass, but it is independent of the
scheduling/COUNT optimization. I removed the Stream Load locking changes from
this PR in 0afd4837804 and moved the fix to #68964, including HTTP transaction
cleanup on lock timeout and 15 passing focused FE tests. This PR retains its
scheduling/COUNT changes; 33 focused FE tests pass after the separation. The
baseline test establishes that the race predates this PR, but does not
establish why that particular Cloud CI run triggered it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
