mrhhsg commented on PR #63258: URL: https://github.com/apache/doris/pull/63258#issuecomment-6123080004
Amended to 4494c5ef516 (replaces c8b95c634a7, same scope). A micro-benchmark showed that copying `column_metas` per block on the unicast path cost O(columns) per block (about 29 µs/block at 100 columns in an ASAN build, against 1 µs for the old `Swap`), which was a real regression for wide tables on the default shuffle path. `borrow_block()` therefore now takes a `BlockSource`: OWNED (unicast) blocks hand their metadata over with an O(1) `Swap`, SHARED (broadcast) blocks keep the copy the broadcast multi-block path already did. The payload is never copied in either case, and the http path is unchanged. Also widened `mem_byte` in `_send_rpc` to `int64_t`, since a >= 2 GiB block (the http case that multi-block mode can now send) wrapped the `int`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
